feat: core url fixes SOFIE-94 #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
force-pushed
the
feat/core-url-fixes
branch
from
a747fba to
b960abd
Compare
Julusian
force-pushed
the
feat/core-url-fixes
branch
from
cda887e to
9a3d984
Compare
Julusian
force-pushed
the
feat/core-url-fixes
branch
from
9a3d984 to
d6747a9
Compare
Julusian
added a commit
that referenced
this pull request
Mar 13, 2025
Julusian
added a commit
that referenced
this pull request
Mar 26, 2025
Julusian
added a commit
that referenced
this pull request
Apr 7, 2025
Julusian
added a commit
that referenced
this pull request
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks to be working, it is controlled by the meteor ROOT_URL environment variable, should be set to something like
http://my-domain/sofie/.I have tested this in dev with and without a subdir, both direct and behind nginx.
And in docker both with and without a subdir.